IonWarp
IonWarpbotexample reviewIonWarp Review — PR #412
3 issues| 2 P1 1 P2
#SevIssueFile
1Second timeout parser reads a bare number as seconds, not millisecondslib/review-timeout.ts
2Import still points to the helper deleted by this PRlib/tasks.ts
3The fix patches one caller; the shared client still drops the errorapi/teams.ts
lib/review-timeout.ts
717273
−+
const timeoutMs = parseReviewTimeout(value);const timeoutMs = parseDurationMs(value);// shared parser owns supported units and validation
A second timeout parser reads numbers differently · AI Architecture Review
The new review-only parser duplicates the platform duration parser but treats a bare number as seconds instead of milliseconds. Use the shared parser and delete the duplicate.
Suggested fixAI fix prompt
P2Dead branches in getBaseConditions: auth conditions are never falsy · AI Architecture Review
getBaseConditions() branches on `authConditions && filterConditions` then `else if (authConditions)`, but getAuthorizationConditions() is declared `Promise<Prisma.Sql>` and every return path (user/org/team scope, invalid options, non-owner/admin) yields a Prisma.Sql object, which is always truthy. The `else if (filterConditions)` and final `else return NOTHING_CONDITION` branches can therefore never run; they are defensive scaffolding for a null-auth case that cannot occur.